move v2 APIs into v1 APIs#9501
Merged
mangalaman93 merged 2 commits intomainfrom Sep 11, 2025
Merged
Conversation
github-actions
Bot
added
area/testing
mangalaman93
force-pushed
the
aman/v1
branch
from
2fd0c5e to
6ca9ed7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the API structure by consolidating v2 APIs into the standard v1 API package, removing the separate v2 API layer and updating all imports and type references accordingly.
Key changes:
- Consolidates all v2 API types and methods into the standard api package
- Updates imports throughout the codebase from
api.v2toapi - Removes the v2-specific server implementation and integrates functionality into the main server
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| worker/import.go | Updates all type references from apiv2 to api package |
| protos/pb/pb_grpc.pb.go | Removes api_v2 import and updates all type references to use api package |
| protos/pb.proto | Removes api.v2 import and updates service definitions to use api types |
| protos/patch_pb.sh | Adds cross-platform sed function for better macOS/Linux compatibility |
| protos/depcheck.sh | Adds homebrew protobuf path support for macOS |
| protos/Makefile | Removes api.v2 proto copying and adds homebrew include path |
| go.mod | Updates dgo dependency to newer version |
| edgraph/zero.go | Changes ServerV25 to Server and updates type references |
| edgraph/server.go | Consolidates v2 methods into main Server struct |
| edgraph/query.go | Simplifies RunDQL implementation and removes v2-specific logic |
| edgraph/ns_query_no_acl_test.go | Removes entire test file |
| edgraph/namespace.go | Significantly simplifies namespace operations and removes v2 complexities |
| edgraph/alter.go | Removes entire v2-specific alter implementation |
| dgraph/cmd/mcp/mcp_server.go | Updates schema setting call to remove namespace parameter |
| dgraph/cmd/dgraphimport/import_client.go | Updates client creation to use standard API client |
| dgraph/cmd/alpha/run.go | Removes v2 server registration |
| .trunk/trunk.yaml | Updates trunk version and linter versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mangalaman93
force-pushed
the
aman/v1
branch
from
782b16c to
ab3ef60
Compare
mangalaman93
force-pushed
the
aman/v1
branch
from
ab3ef60 to
42609ca
Compare
|
|
shivaji-kharse
force-pushed
the
aman/v1
branch
from
972aab2 to
b031452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.